Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: second expand volume failure on Ubuntu 22.04 #1728

Merged
merged 1 commit into from
Feb 16, 2023
Merged

fix: second expand volume failure on Ubuntu 22.04 #1728

merged 1 commit into from
Feb 16, 2023

Conversation

andyzhangx
Copy link
Member

@andyzhangx andyzhangx commented Feb 15, 2023 •
edited
Loading

What type of PR is this?
/kind bug

What this PR does / why we need it:
fix: second expand volume failure on Ubuntu 22.04
This is related to bug: https://bugzilla.redhat.com/show_bug.cgi?id=2128863 on Ubuntu 22.04, second resize2fs always failed with following error:

  Warning  FailedMount             0s (x5 over 8s)  kubelet                  MountVolume.Setup failed while expanding volume for volume "pvc-8e0170f3-c7f1-413d-909f-5f1c7487f098" : Expander.NodeExpand failed to expand the volume : rpc error: code = Internal desc = could not resize volume "/subscriptions/xxx/resourceGroups/mc_andy-aks125_andy-aks125_eastus2/providers/Microsoft.Compute/disks/pvc-8e0170f3-c7f1-413d-909f-5f1c7487f098" ("/dev/sdc"):  resize of device /dev/sdc failed: exit status 1. resize2fs output: resize2fs 1.46.4 (18-Aug-2021)
resize2fs: Superblock checksum does not match superblock while trying to open /dev/sdc
Couldn't find valid filesystem superblock.

When hit resize2fs error, this PR would continue check volume size, if it's expected resized size, then return success.

  • workaround
    delete pod make it remount would work or using online resize directly which would not hit this issue.

Which issue(s) this PR fixes:

Fixes #1631

Requirements:

Special notes for your reviewer:

Release note:

fix: second expand volume failure on Ubuntu 22.04

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Feb 15, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 15, 2023
@andyzhangx andyzhangx mentioned this pull request Feb 15, 2023
Closed
@andyzhangx andyzhangx removed the request for review from edreed February 15, 2023 06:34
@andyzhangx andyzhangx changed the title fix: second expand volume failure on Ubuntu 22.04 [WIP]fix: second expand volume failure on Ubuntu 22.04 Feb 15, 2023
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 15, 2023
@andyzhangx andyzhangx changed the title [WIP]fix: second expand volume failure on Ubuntu 22.04 fix: second expand volume failure on Ubuntu 22.04 Feb 16, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 16, 2023
@andyzhangx andyzhangx merged commit 9690bc4 into kubernetes-sigs:master Feb 16, 2023
@andyzhangx
Copy link
Member Author

/cherrypick release-1.26

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Feb 28, 2023
Merged
@k8s-infra-cherrypick-robot
Copy link

@andyzhangx: new pull request created: #1743

In response to this:

/cherrypick release-1.26

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sunnylovestiramisu sunnylovestiramisu mentioned this pull request Mar 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZeroMagic ZeroMagic Awaiting requested review from ZeroMagic

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CSI volume test failing on newer Ubuntu 20.04 image
3 participants
@andyzhangx @k8s-ci-robot @k8s-infra-cherrypick-robot